Support for running OFRAK on arm64 Linux #562
Conversation
…le multiarch support
…, we'd have 100% test coverage on arm. Oh well, maybe a job for a different pr...
|
test currently failing because the bumped angr version requires python >=3.10. I guess we can set a complex requirement for it |
Is the bumped angr version the minimum version that will work? |
| raw_value = config.get(section, key) | ||
|
|
||
| if "*" in raw_value: | ||
| matches = glob.glob(raw_value) | ||
| if matches: | ||
| return matches[0] | ||
| else: | ||
| raise NotFoundError(f"No file matches wildcard {raw_value}") | ||
| else: | ||
| return raw_value |
There was a problem hiding this comment.
I don't feel very positively about this change to use globbing. I personally feel that it makes the config file harder to read and understand. It also seems kind of error-prone for anyone not running OFRAK inside of Docker, who may have their own toolchains installed on their system.
@Jepson2k @alchzh what alternatives were considered here instead of globbing?
|
Changed it so that toolchain.conf can be read from the Left the current toolchain.conf in place to avoid breaking anyone's setup if they install a newer version. I want to update it to one without absolute paths in the future though so users can use executables that exist on their local PATH |
Authored by @Jepson2k
One sentence summary of this PR (This should go in the CHANGELOG!)
Added support for running OFRAK on arm64 Linux
Link to Related Issue(s)
#549
Please describe the changes in your request.
0.16.1for arm binaries9.2.133for arm binaries5.0.3for arm binaries3.10.12for arm binariestoolchain.confto account for naming differences between platformsAnyone you think should look at this, specifically?
@rbs-jacob