Feature/cached disasm #556
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests are passing
…sing generated json files
added 2 commits
January 3, 2025 15:23
added 3 commits
January 8, 2025 14:50
dannyp303
commented
Jan 8, 2025
| ) | ||
|
|
||
|
|
||
| class CachedProgramUnpacker(Unpacker[None]): |
There was a problem hiding this comment.
This component is untested due to code regions being unpacked by the ELF unpacker, could be useful for raw binaries, maybe should be removed?
…to feature/cached_disasm
dannyp303
commented
Jan 9, 2025
Comment on lines
+54
to
+55
| class CachedCodeRegionModifier(CachedCodeRegionModifier): | ||
| pass |
There was a problem hiding this comment.
The cached code region unpacker runs this modifier directly, this is a workaround to have it be discoverable with only pyghidra components injected. I tested that it does not cause conflicts if both the cached_disassembly and pyghidra are injected at the same time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One sentence summary of this PR (This should go in the CHANGELOG!)
Creates two new disassemblers for OFRAK, ofrak_pyghidra using the PyGhidra feature in the ghidra repository, and ofrak_cached for cacheing binary analysis.
Link to Related Issue(s)
None
Please describe the changes in your request.
ofrak_pyghidra.components: One single unpacker that unpacks the entire binary, down to instruction level, with an option switch to not unpack basic blocks into instructions.ofrak_pyghidra.standalone(name pending): A utility completely seperate from OFRAK that uses pyghidra to generate the cache file used inofrak_cachedofrak_cached.components: OFRAK components that ingest a cached analysis file, associates it with a resource id, and uses it to unpack the binary as requested.Anyone you think should look at this, specifically?
@rbs-jacob