Add support for running on Windows to the Filesystem component and fix path handling on Windows #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use sys.platform checks to please mypy check sys.platform not platform.system Use sys.platform checks to please mypy check sys.platform not platform.system
alchzh
changed the title
rbs-jacob
requested changes
Dec 4, 2024
rbs-jacob
approved these changes
Dec 4, 2024
|
@whyitfor reminded me that this also needs a changelog entry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One sentence summary of this PR (This should go in the CHANGELOG!)
Add support for running on Windows to the Filesystem component.
Link to Related Issue(s)
Part of a set of Windows-related changes with #486 and #487 . All three are required to get >90% of tests passing on Windows
Please describe the changes in your request.
posixpathlibrary andPath.as_posix()to make internal path handling consistentosmethods on Windows (mkfifo,chown,chmod, etc.)rootandextractsubdirectories of one temporary directory (debugging QoL)Anyone you think should look at this, specifically?