Refactor run_component to utilize full pjson serialization #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbs-jacob
requested changes
Aug 19, 2024
rbs-jacob
approved these changes
Jan 9, 2025
|
Something is wrong here, seems like this change has broken Enums in the config serializer.
|
dannyp303
requested changes
Jan 14, 2025
| if (node["default"] != null) { | ||
| element = node["default"]; | ||
|
|
||
| $: if (node["type"].startsWith("ofrak")) { |
There was a problem hiding this comment.
Suggested change
| $: if (node["type"].startsWith("ofrak")) { | |
| $: if (node["type"].startsWith("ofrak") && node["enum"] == null) { |
there are ofrak classes that are Enum, and should be handled as a Enum, not an ofrak class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One sentence summary of this PR (This should go in the CHANGELOG!)
Link to Related Issue(s)
Please describe the changes in your request.
Anyone you think should look at this, specifically?