Draft
Conversation
gharlan
reviewed
Jul 4, 2025
Member
There was a problem hiding this comment.
Das Verschieben der Funktionen in eine andere Datei macht es mir tendenziell schwieriger bzgl. R6-Merge etc.
|
|
||
| $(document).on('rex:ready',function() { | ||
|
|
||
| $(".rex-js-widget-media").each(function () { |
Member
There was a problem hiding this comment.
Bei rex:ready sollte man den Container entgegen nehmen, der ausgetauscht wurde, und nur innerhalb Element initialisieren etc.
Hier ein Beispiel: https://github.com/redaxo/redaxo/blob/1a930bcda060ba4c5c55aa14938a4113b7237b78/redaxo/src/addons/be_style/assets/javascripts/main.js#L1-L2
Also inbesondere dann mit container.find() statt global $() arbeiten.
(Beim initialen Aufruf ist container das <body>-Element.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.