Syncing latest changes from main for odf-operator #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github.com/census-instrumentation/opencensus-go repository was archived on the Jul 31, 2023 and url go.opencensus.io holding these libraries is not available anymore. Though it is still available on the proxy server. But we are using GOPROXY="direct,https://proxy.golang.org" which tries to fetch it from the go.opencensus.io and throws an error. To fix this we are now starting pulling it directly from the github archived repo. once we start using GOPROXY="https://proxy.golang.org,direct" we can revert this change as well. while reverting 6cb13e9 we also need to revert this. Signed-off-by: Nitin Goyal <[email protected]>
godeps: fix an error 'unrecognized import path "go.opencensus.io"'
Docker requires consistent casing for keywords. If a keyword is in uppercase, all keywords should be in uppercase. If a keyword is in lowercase, all keywords should be in lowercase. The following warning appears while building images: FromAsCasing: 'as' and 'FROM' keywords' casing do not match Signed-off-by: Nitin Goyal <[email protected]>
dockerfile: fix casing warning in Dockerfile
iamniting
approved these changes
Jan 30, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: df-build-team, iamniting The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR containing the latest commits from main branch