feat: Add StorageID field to secrets and use it for replication ID #259
+378
−153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbnrh
force-pushed
the
fix-replication-id
branch
2 times, most recently
from
d6d2e52 to
ee4a201
Compare
|
/assign @umangachapagain |
|
/test integration-test |
Adds a new StorageID field to blue/green secrets and updates the replication ID generation to use storage IDs instead of FSIDs. Key changes: - Add storage_id field to all secret types (blue/green/hub) - Update secret handlers to properly propagate storage IDs between secrets - Add helper functions to get storage IDs from different secret types - Update replication ID generation to use storage IDs instead of FSIDs - Add tests for storage ID handling and verification - Update labelCephClusters to use storage IDs for replication ID Signed-off-by: vbadrina <[email protected]>
vbnrh
force-pushed
the
fix-replication-id
branch
from
ee4a201 to
774d763
Compare
umangachapagain
approved these changes
Feb 13, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: umangachapagain, vbnrh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test integration-test |
openshift-merge-bot
bot
merged commit ec76c39
into
red-hat-storage:main
11 checks passed
|
/cherrypick release-4.18 |
|
@vbnrh: new pull request created: #260 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new StorageID field to blue/green secrets and updates the replication ID generation to use storage IDs instead of FSIDs. Key changes: