Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix StorageClusterPeer API endpoint #257

Merged
merged 2 commits into from
Feb 11, 2025
Merged

Fix StorageClusterPeer API endpoint #257

merged 2 commits into from
Feb 11, 2025
+39 −22

Conversation

umangachapagain
Copy link
Contributor

No description provided.

@umangachapagain
update ocs-operator dependency
90c0139 
Signed-off-by: Umanga Chapagain <[email protected]>
@rewantsoni
Copy link
Member

LGTM

@umangachapagain umangachapagain force-pushed the storageclusterpeer-endpoint branch from 5963ae3 to 99cafef Compare February 11, 2025 10:00
@vbnrh
Copy link
Member

vbnrh commented Feb 11, 2025

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Feb 11, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: umangachapagain, vbnrh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [umangachapagain,vbnrh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@umangachapagain umangachapagain force-pushed the storageclusterpeer-endpoint branch from 99cafef to afcc8c7 Compare February 11, 2025 10:57
@openshift-ci openshift-ci bot removed the lgtm label Feb 11, 2025
@umangachapagain umangachapagain force-pushed the storageclusterpeer-endpoint branch from afcc8c7 to affe416 Compare February 11, 2025 13:32
@umangachapagain umangachapagain force-pushed the storageclusterpeer-endpoint branch from affe416 to b676f19 Compare February 11, 2025 14:16
@umangachapagain
Copy link
Contributor Author

/cherry-pick release-4.18

@openshift-cherrypick-robot
Copy link

@umangachapagain: once the present PR merges, I will cherry-pick it on top of release-4.18 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@vbnrh
Copy link
Member

vbnrh commented Feb 11, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 11, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 6a041c3 into red-hat-storage:main Feb 11, 2025
11 checks passed
@openshift-cherrypick-robot
Copy link

@umangachapagain: new pull request created: #258

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 11, 2025
Open
@umangachapagain umangachapagain deleted the storageclusterpeer-endpoint branch February 11, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbnrh vbnrh Awaiting requested review from vbnrh

@rewantsoni rewantsoni Awaiting requested review from rewantsoni

Assignees

@vbnrh vbnrh

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@umangachapagain @rewantsoni @vbnrh @openshift-cherrypick-robot