-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix security issue: Backtracking regular expressions #1596
base: master
Are you sure you want to change the base?
Fix security issue: Backtracking regular expressions #1596
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: alfonsomthd The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -61,7 +61,6 @@ | |||
"react": "^17.0.1", | |||
"react-dom": "^17.0.1", | |||
"react-i18next": "^11.11.4", | |||
"react-router": "5.3.x", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SanjalKatiyar in the external plugin that uses the shared library we're using react-router-dom-v5-compat
.
cc @aruniiird |
1b56019
to
46125c9
Compare
I think this express package update will solve all other CVEs, almost 90% CVEs that we got have problems with this express dependency only. |
LGTM |
1 similar comment
LGTM |
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2311004
Update
path-to-regexp
to patched versions:express
to a version that requires a patched version ofpath-to-regexp
.react-router
v5 that haspath-to-regexp
as dependency.react-router-dom-v5-compat
can be replaced withreact-router
v6 in a follow-up PR.path-to-regexp
version installed by@openshift-console/dynamic-plugin-sdk-internal
is a patched version.