Skip to content

Conversation

@rewantsoni
Copy link
Member

@rewantsoni rewantsoni commented Sep 26, 2025

Create and distribute the default network fence classes

Depends on: red-hat-storage/ocs-client-operator#475

Part of: RHSTOR-6840

@rewantsoni rewantsoni force-pushed the nfc branch 2 times, most recently from c296c7c to b35738c Compare September 29, 2025 06:55
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 30, 2025
@rewantsoni rewantsoni force-pushed the nfc branch 2 times, most recently from 012f1ba to 863e239 Compare October 6, 2025 10:29
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 6, 2025
@rewantsoni
Copy link
Member Author

/retest-required

1 similar comment
@rewantsoni
Copy link
Member Author

/retest-required

@rewantsoni rewantsoni force-pushed the nfc branch 2 times, most recently from 19cab2e to d506ace Compare October 7, 2025 07:05
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 8, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 9, 2025
@rewantsoni
Copy link
Member Author

/retest-required

1 similar comment
@rewantsoni
Copy link
Member Author

/retest-required

Copy link
Member

@Madhu-1 Madhu-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, small nits

@rewantsoni
Copy link
Member Author

Testing:

rewantsoni@Mac ~/work/qe ❯ k get storageconsumer -A -oyaml
apiVersion: v1
items:
- apiVersion: ocs.openshift.io/v1alpha1
  kind: StorageConsumer
  metadata:
    creationTimestamp: "2025-10-13T10:44:15Z"
    finalizers:
    - ocs.openshift.io/internal-component
    - ocs.openshift.io/storageconsumer-protection
    generation: 30
    labels:
      ocs.openshift.io/created-at-df-version: "4.20"
    name: internal
    namespace: openshift-storage
    ownerReferences:
    - apiVersion: ocs.openshift.io/v1
      blockOwnerDeletion: true
      controller: true
      kind: StorageCluster
      name: test-storagecluster
      uid: 37b46a6a-d3f6-4230-8a42-689a509cd896
    resourceVersion: "45413"
    uid: 0da38b44-9a81-43e1-9817-9609e1733197
  spec:
    enable: true
    networkFenceClasses:
    - name: test-storagecluster-ceph-rbd-networkfenceclass
    resourceNameMappingConfigMap:
      name: storageconsumer-internal
    storageClasses:
    - name: test-storagecluster-cephfs
    - name: test-storagecluster-ceph-nfs
    - name: test-storagecluster-ceph-rbd
    volumeGroupSnapshotClasses:
    - name: test-storagecluster-ceph-rbd-groupsnapclass
    - name: test-storagecluster-cephfs-groupsnapclass
    volumeSnapshotClasses:
    - name: test-storagecluster-rbdplugin-snapclass
    - name: test-storagecluster-cephfsplugin-snapclass
    - name: test-storagecluster-nfsplugin-snapclass
    
rewantsoni@Mac ~/work/qe 3m 13s ❯ k get networkfenceclass -A -oyaml
apiVersion: v1
items:
- apiVersion: csiaddons.openshift.io/v1alpha1
  kind: NetworkFenceClass
  metadata:
    annotations:
      ramendr.openshift.io/storageid: 7dc94555dc69a1fba5386506320aadb7
    creationTimestamp: "2025-10-13T10:49:01Z"
    finalizers:
    - csiaddons.openshift.io/csiaddonsnode
    generation: 1
    name: test-storagecluster-ceph-rbd-networkfenceclass
    ownerReferences:
    - apiVersion: ocs.openshift.io/v1alpha1
      blockOwnerDeletion: true
      controller: true
      kind: StorageClient
      name: test-storagecluster
      uid: 8824a76f-1caf-4cdf-9a63-8bdd452c5749
    resourceVersion: "45077"
    uid: 15b8ba95-11a5-49a6-b97e-b9175f17cb28
  spec:
    parameters:
      csiaddons.openshift.io/networkfence-secret-name: rook-csi-rbd-provisioner
      csiaddons.openshift.io/networkfence-secret-namespace: openshift-storage
    provisioner: openshift-storage.rbd.csi.ceph.com
kind: List
metadata:
  resourceVersion: ""

@rewantsoni rewantsoni force-pushed the nfc branch 2 times, most recently from ff1a4a2 to f23b63c Compare October 13, 2025 12:23
@Madhu-1
Copy link
Member

Madhu-1 commented Oct 13, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2025
@leelavg
Copy link
Contributor

leelavg commented Oct 13, 2025

/approved
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2025
@leelavg leelavg added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: leelavg, Madhu-1, rewantsoni

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit c174821 into red-hat-storage:main Oct 13, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants