Skip to content

Add liveness probe to OCS Operator #3449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2025
+52 −6
Merged

Add liveness probe to OCS Operator #3449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions config/manager/manager.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,9 @@ spec:
image: ocs-dev/ocs-operator:latest
imagePullPolicy: Always
name: ocs-operator
ports:
- name: healthz
containerPort: 8081
env:
- name: WATCH_NAMESPACE
valueFrom:
Expand All @@ -38,13 +41,23 @@ spec:
readinessProbe:
httpGet:
path: /readyz
port: 8081
port: healthz
initialDelaySeconds: 5
periodSeconds: 10
timeoutSeconds: 5
failureThreshold: 3
livenessProbe:
httpGet:
path: /healthz
port: healthz
initialDelaySeconds: 15
periodSeconds: 10
timeoutSeconds: 5
failureThreshold: 3
securityContext:
allowPrivilegeEscalation: false
capabilities:
drop:
drop:
- all
readOnlyRootFilesystem: true
terminationMessagePolicy: FallbackToLogsOnError
Expand Down
17 changes: 15 additions & 2 deletions deploy/csv-templates/ocs-operator.csv.yaml.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ metadata:
"spec": null
}
]
createdAt: "2025-10-15T10:57:28Z"
createdAt: "2025-10-30T10:14:09Z"
description: Red Hat OpenShift Container Storage provides hyperconverged storage
for applications within an OpenShift cluster.
operators.operatorframework.io/builder: operator-sdk-v1.30.0
Expand Down Expand Up @@ -624,13 +624,26 @@ spec:
fieldPath: metadata.annotations['olm.targetNamespaces']
image: quay.io/ocs-dev/ocs-operator:latest
imagePullPolicy: Always
livenessProbe:
failureThreshold: 3
httpGet:
path: /healthz
port: healthz
initialDelaySeconds: 15
periodSeconds: 10
timeoutSeconds: 5
name: ocs-operator
ports:
- containerPort: 8081
name: healthz
readinessProbe:
failureThreshold: 3
httpGet:
path: /readyz
port: 8081
port: healthz
initialDelaySeconds: 5
periodSeconds: 10
timeoutSeconds: 5
resources: {}
securityContext:
allowPrivilegeEscalation: false
Expand Down
17 changes: 15 additions & 2 deletions deploy/ocs-operator/manifests/ocs-operator.clusterserviceversion.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ metadata:
capabilities: Deep Insights
categories: Storage
containerImage: quay.io/ocs-dev/ocs-operator:latest
createdAt: "2025-10-15T10:57:28Z"
createdAt: "2025-10-30T10:14:09Z"
description: Red Hat OpenShift Container Storage provides hyperconverged storage
for applications within an OpenShift cluster.
external.features.ocs.openshift.io/supported-platforms: '["BareMetal", "None",
Expand Down Expand Up @@ -663,13 +663,26 @@ spec:
fieldPath: metadata.namespace
image: quay.io/ocs-dev/ocs-operator:latest
imagePullPolicy: Always
livenessProbe:
failureThreshold: 3
httpGet:
path: /healthz
port: healthz
initialDelaySeconds: 15
periodSeconds: 10
timeoutSeconds: 5
name: ocs-operator
ports:
- containerPort: 8081
name: healthz
readinessProbe:
failureThreshold: 3
httpGet:
path: /readyz
port: 8081
port: healthz
initialDelaySeconds: 5
periodSeconds: 10
timeoutSeconds: 5
resources:
limits:
cpu: 250m
Expand Down
7 changes: 7 additions & 0 deletions main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ import (
ctrl "sigs.k8s.io/controller-runtime"
"sigs.k8s.io/controller-runtime/pkg/cache"
apiclient "sigs.k8s.io/controller-runtime/pkg/client"
"sigs.k8s.io/controller-runtime/pkg/healthz"
"sigs.k8s.io/controller-runtime/pkg/log/zap"
"sigs.k8s.io/controller-runtime/pkg/manager"
metrics "sigs.k8s.io/controller-runtime/pkg/metrics/server"
Expand Down Expand Up @@ -305,6 +306,12 @@ func main() {
os.Exit(1)
}

// Liveness (/healthz)
if err := mgr.AddHealthzCheck("healthz", healthz.Ping); err != nil {
setupLog.Error(err, "unable to add a health check")
os.Exit(1)
}

// Add readiness probe
if err := mgr.AddReadyzCheck("readyz", storagecluster.ReadinessChecker); err != nil {
setupLog.Error(err, "unable add a readiness check")
Expand Down
Loading