provider: add annotation to StorageCluster about deployment mode #2717
Conversation
|
/hold for more testing |
openshift-ci
bot
added
the
do-not-merge/hold
| @@ -330,11 +331,18 @@ func (r *StorageClusterReconciler) reconcilePhases( | |||
|
|
|||
| // Check GetDeletionTimestamp to determine if the object is under deletion | |||
| if instance.GetDeletionTimestamp().IsZero() { | |||
| var instanceUpdateRequired bool | |||
| if instance.Spec.AllowRemoteStorageConsumers && util.AddAnnotation(instance, "mode", "provider") { | |||
There was a problem hiding this comment.
Please use a standardized annotation name ocs.openshift.io/deployment_mode or something similar
|
LGTM, but prefer the @iamniting will also take a look |
setting an annotation on the storagecluster allows to only look at metadata for finding the configured mode rather than parsing the spec. Signed-off-by: Leela Venkaiah G <[email protected]>
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/cherry-pick release-4.16 |
|
@leelavg: once the present PR merges, I will cherry-pick it on top of release-4.16 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Tested as mentioned in red-hat-storage/ocs-client-operator#196 (comment) |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iamniting, leelavg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit 930a78b
into
red-hat-storage:main
|
@leelavg: new pull request created: #2724 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-4.17 |
|
@leelavg: new pull request could not be created: failed to create pull request against red-hat-storage/ocs-operator#release-4.17 from head openshift-cherrypick-robot:cherry-pick-2717-to-release-4.17: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between red-hat-storage:release-4.17 and openshift-cherrypick-robot:cherry-pick-2717-to-release-4.17"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
disregard. |
setting an annotation on the storagecluster allows to only look at metadata for finding the configured mode rather than parsing the spec.
this helps for client-operator to decide reconciliation.