Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable sse-s3 setting for rgw when cluster-wide-encryption enabled #2509

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

enable sse-s3 setting for rgw when cluster-wide-encryption enabled #2509

wants to merge 1 commit into from

Conversation

thotz
Copy link
Contributor

@thotz thotz commented Mar 15, 2024

Currently only sse-kms settings are enabled.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 21, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, thotz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 21, 2024
@iamniting
Copy link
Member

/test ocs-operator-bundle-e2e-aws

2 similar comments
@iamniting
Copy link
Member

/test ocs-operator-bundle-e2e-aws

@iamniting
Copy link
Member

/test ocs-operator-bundle-e2e-aws

@iamniting
Copy link
Member

@thotz Can you pls rebase your changes

@agarwal-mudit
Copy link
Member

/retest

@iamniting
Copy link
Member

/retest

@agarwal-mudit We need rebase

@thotz
Copy link
Contributor Author

thotz commented Mar 25, 2024

@agarwal-mudit @iamniting this PR is not mandatory for 4.16 release the RGW-Vault epic moved out of 4.16 release

@thotz thotz force-pushed the sse-s3-rgw-vault branch from c0aad1e to 7f4933f Compare March 25, 2024 13:53
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 25, 2024

New changes are detected. LGTM label has been removed.

@iamniting
Copy link
Member

Lets put it on hold for now, in that case.
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 25, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 25, 2024

@thotz: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ocs-operator-bundle-e2e-aws 7f4933f link true /test ocs-operator-bundle-e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamniting iamniting iamniting approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

@iamniting iamniting

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thotz @iamniting @agarwal-mudit