godeps: update go version to 1.23.0 and fetched latest ocs-op deps #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
need to add changes for golangci-lint |
rchikatw
reviewed
Feb 14, 2025
leelavg
approved these changes
Feb 14, 2025
|
/hold as I see a comment, unhold after addressing the comment. |
|
I still see changes in single commit, as per resolved thread it was decided to have 2 commits isn't it? go version update and ocs-deps update? |
Signed-off-by: Rohan Gupta <[email protected]>
Signed-off-by: Rohan Gupta <[email protected]>
Updated |
leelavg
reviewed
Feb 18, 2025
vendor/github.com/red-hat-storage/ocs-operator/services/provider/api/v4/client/client.go
Show resolved
Hide resolved
leelavg
approved these changes
Feb 18, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leelavg, rohan47 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
openshift-merge-bot
bot
merged commit 3d7105e
into
red-hat-storage:main
12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update go version to 1.23.0
fetched latest dependencies of ocs-op