Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

controllers: trigger reconcile for claims when the desired hash changes #299

Merged

Conversation

rewantsoni
Copy link
Member

add a watch for storageClient annotation change in the claim controller

@rewantsoni
Copy link
Member Author

/hold for Testing

@rewantsoni
Copy link
Member Author

Testing:

[rewantsoni malay] k get storagecluster ocs-storagecluster -oyaml | yq '.spec.network.connections'      
encryption:
  enabled: false

[rewantsoni malay] k get clientProfile 37449e1277731e6cfa1ded34fcf6639d -oyaml | yq '.spec.cephFs'
kernelMountOptions:
  ms_mode: prefer-crc
subVolumeGroup: cephfilesystemsubvolumegroup-7d512af0f18240c78d8b4ccc1ddb1a9c

Enabling encryption-------
[rewantsoni malay] k patch storagecluster ocs-storagecluster -n openshift-storage --type json --patch '[{ "op": "replace", "path": "/spec/network", "value": {"connections": {"encryption": {"enabled": true}}} }]' 
storagecluster.ocs.openshift.io/ocs-storagecluster patched
[rewantsoni malay] k get storagecluster ocs-storagecluster -oyaml | yq '.spec.network.connections'                                                                                                                  
encryption:
  enabled: true

[rewantsoni malay] k get clientProfile 37449e1277731e6cfa1ded34fcf6639d -oyaml | yq '.spec.cephFs'
kernelMountOptions:
  ms_mode: secure
subVolumeGroup: cephfilesystemsubvolumegroup-7d512af0f18240c78d8b4ccc1ddb1a9c

@rewantsoni rewantsoni requested a review from leelavg February 6, 2025 06:48
@@ -130,6 +131,24 @@ func (r *StorageClaimReconciler) SetupWithManager(mgr ctrl.Manager) error {
}
}

// Reconcile the OperatorConfigMap object when the cluster's version object is updated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

incorrect comment, can be removed.

@rewantsoni rewantsoni force-pushed the claim-controller branch 3 times, most recently from 9ad4d76 to 2ec79d1 Compare February 6, 2025 07:18
add a watch for storageClient annotation change in the claim controller

Signed-off-by: Rewant Soni <[email protected]>
Copy link

openshift-ci bot commented Feb 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leelavg, rewantsoni

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rewantsoni
Copy link
Member Author

/unhold tested the fix and it works

@openshift-ci openshift-ci bot added the approved label Feb 6, 2025
@rewantsoni
Copy link
Member Author

/cherry-pick release-4.18

@openshift-cherrypick-robot

@rewantsoni: once the present PR merges, I will cherry-pick it on top of release-4.18 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 41fd975 into red-hat-storage:main Feb 6, 2025
10 checks passed
@openshift-cherrypick-robot

@rewantsoni: new pull request created: #300

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants