-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
controllers: trigger reconcile for claims when the desired hash changes #299
controllers: trigger reconcile for claims when the desired hash changes #299
Conversation
/hold for Testing |
78121c9
to
53583df
Compare
53583df
to
2af7ddf
Compare
Testing:
|
@@ -130,6 +131,24 @@ func (r *StorageClaimReconciler) SetupWithManager(mgr ctrl.Manager) error { | |||
} | |||
} | |||
|
|||
// Reconcile the OperatorConfigMap object when the cluster's version object is updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
incorrect comment, can be removed.
2af7ddf
to
9d3efba
Compare
9ad4d76
to
2ec79d1
Compare
add a watch for storageClient annotation change in the claim controller Signed-off-by: Rewant Soni <[email protected]>
2ec79d1
to
b142a2d
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leelavg, rewantsoni The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold tested the fix and it works |
/cherry-pick release-4.18 |
@rewantsoni: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
41fd975
into
red-hat-storage:main
@rewantsoni: new pull request created: #300 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
add a watch for storageClient annotation change in the claim controller