Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support sort order and null placement options in Vector#rank #265

Merged
merged 1 commit into from
Aug 5, 2023
Merged

Support sort order and null placement options in Vector#rank #265

merged 1 commit into from
Aug 5, 2023

Conversation

heronshoes
Copy link
Contributor

@heronshoes heronshoes commented Aug 4, 2023 •
edited
Loading

Closes #264 .

  • Supported :order option as sort order.
  • Supported :null_placement option.
  • Refine tests and documents.
  • Don't pack for ChunkedArray. Now rank kernel supports it.
  • Changed 0-based to 1-based numerical rank.

@heronshoes heronshoes merged commit 17979a4 into main Aug 5, 2023
7 checks passed
@heronshoes heronshoes deleted the refine_rank branch August 5, 2023 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support sort_order and null_placement options in Vector#rank
1 participant
@heronshoes