Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vectors #159

Merged
merged 20 commits into from
Jan 26, 2025
Merged

Add vectors #159

merged 20 commits into from
Jan 26, 2025

Conversation

Ketasaja
Copy link
Contributor

@Ketasaja Ketasaja commented Jan 24, 2025 •
edited
Loading

Adds faster vector type and keyword. Vector3 and vector are perfectly compatible at runtime but have different types.

Future change could be for Vector to store NumTys instead of Tys but NumTy doesn't have ranges right now. Alternative was Vector<Box<NumTy>, Box<NumTy>, Option<Box<NumTy>, Option, Option, Option>` which I didn't like.

@sasial-dev sasial-dev marked this pull request as draft January 25, 2025 01:35
@sasial-dev sasial-dev self-assigned this Jan 25, 2025
@sasial-dev sasial-dev marked this pull request as ready for review January 25, 2025 06:14
sasial-dev
sasial-dev requested changes Jan 25, 2025
View reviewed changes
Copy link
Collaborator

@sasial-dev sasial-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix clippy lints as well!

zap/src/config.rs Outdated Show resolved Hide resolved
zap/src/parser/grammar.lalrpop Outdated Show resolved Hide resolved
@Ketasaja Ketasaja requested a review from sasial-dev January 25, 2025 16:03
@sasial-dev
Copy link
Collaborator

sasial-dev commented Jan 25, 2025 •
edited
Loading

Also as vectors are natively testable please add an irgen test! We can't do that until lune-org/lune#299 but that doesn't need to block this PR.

@Ketasaja Ketasaja requested a review from sasial-dev January 26, 2025 00:46
sasial-dev
sasial-dev requested changes Jan 26, 2025
View reviewed changes
docs/config/types.md Outdated Show resolved Hide resolved
zap/src/irgen/mod.rs Outdated Show resolved Hide resolved
zap/src/config.rs Outdated Show resolved Hide resolved
docs/config/types.md Outdated Show resolved Hide resolved
@Ketasaja Ketasaja requested a review from sasial-dev January 26, 2025 04:47
sasial-dev
sasial-dev approved these changes Jan 26, 2025
View reviewed changes
Copy link
Collaborator

@sasial-dev sasial-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sasial-dev sasial-dev merged commit 6e0cefd into red-blox:0.6.x Jan 26, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sasial-dev sasial-dev sasial-dev approved these changes

Assignees

@sasial-dev sasial-dev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ketasaja @sasial-dev