Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop AttributeKey::SCOPE in MethodParameterTypeResolver #3873

Merged
merged 1 commit into from
May 16, 2023
Merged

Drop AttributeKey::SCOPE in MethodParameterTypeResolver #3873

merged 1 commit into from
May 16, 2023

Conversation

staabm
Copy link
Contributor

@staabm staabm commented May 16, 2023

No description provided.

@staabm staabm requested a review from TomasVotruba as a code owner May 16, 2023 16:57
@samsonasik
Copy link
Member

PHPStan notice is due to new release of phpstan-rules that remove the type-coverage-rules.neon, see symplify/phpstan-rules@d7e70a8#diff-b27960a3ca2aeaf23e751a8b5c4d4d16e12e0696e7c5e58f20df634e204d5b1b

I created PR:

for it.

@samsonasik samsonasik closed this May 16, 2023
@samsonasik samsonasik reopened this May 16, 2023
@samsonasik
Copy link
Member

Let's restart build 👍

@samsonasik
Copy link
Member

PHPStan notice will be resolved at rectorphp/rector-downgrade-php#58

@samsonasik samsonasik enabled auto-merge (squash) May 16, 2023 17:07
@samsonasik
Copy link
Member

Thank you @staabm

@samsonasik samsonasik merged commit 83a4a60 into rectorphp:main May 16, 2023
@staabm staabm deleted the scope12 branch May 16, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasVotruba TomasVotruba Awaiting requested review from TomasVotruba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@staabm @samsonasik