Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0] Use BetterNodeFinder::resolveNextNode() on DowngradeNegativeStringOffsetToStrlenRector #59

Merged
merged 2 commits into from
May 21, 2023

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented May 21, 2023

@TomasVotruba @staabm this require PR on rector-src:

this cover next node of: String_, Variable, PropertyFetch, StaticPropertyFetch.

for adding BetterNodeFinder::resolvePreviousNode() and BetterNodeFinder::resolveNextNode() to be merged first.

@samsonasik samsonasik changed the title [V1] Use BetterNodeFinder::resolveNextNode() on DowngradeNegativeStringOffsetToStrlenRector [1.0] Use BetterNodeFinder::resolveNextNode() on DowngradeNegativeStringOffsetToStrlenRector May 21, 2023
@samsonasik
Copy link
Member Author

samsonasik commented May 21, 2023

@TomasVotruba it works 🎉 , PR in rector-src need to be merged first for it:

then normal rector-src dev-main without pin hash can be rolled back.

@samsonasik samsonasik enabled auto-merge (squash) May 21, 2023 22:25
@TomasVotruba TomasVotruba merged commit 79bc835 into main May 21, 2023
@TomasVotruba TomasVotruba deleted the use-next-node branch May 21, 2023 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants