Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Enable zend.assertions ini values in CI #56

Merged
merged 1 commit into from
May 13, 2023

Conversation

samsonasik
Copy link
Member

To show error per fixture #55 (comment)

@samsonasik samsonasik marked this pull request as draft May 13, 2023 15:36
@samsonasik samsonasik marked this pull request as ready for review May 13, 2023 15:38
@samsonasik
Copy link
Member Author

@TomasVotruba the isFirstClassCallable() seems already called on shouldSkip() method, so it works

if ($funcCall->isFirstClassCallable()) {
return true;
}

however, the zend.assertions is needed to be set to 1 to show error early.

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I think it is ready, as per target rule already use $funcCall->isFirstClassCallable(), it doesn't show error.

@samsonasik
Copy link
Member Author

@TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit 76125e6 into main May 13, 2023
@samsonasik samsonasik deleted the enable-zend-assertion branch May 13, 2023 16:43
@TomasVotruba
Copy link
Member

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants