Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary check ReflectionClass on DowngradeReflectionGetAttributesRector #205

Merged
merged 1 commit into from
Nov 5, 2023
Merged

Remove unnecessary check ReflectionClass on DowngradeReflectionGetAttributesRector #205

merged 1 commit into from
Nov 5, 2023

Conversation

samsonasik
Copy link
Member

@malteschlueter Per PR on rector-src

instanceof ReflectionClass no longer needed as it is instanceof Reflector.

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit 4056166 into main Nov 5, 2023
5 checks passed
@samsonasik samsonasik deleted the samsonasik-patch-1 branch November 5, 2023 13:59
@malteschlueter
Copy link
Contributor

Good work :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samsonasik @malteschlueter