[PHPStan] Fix PHPStan notice Attribute must have all names explicitly…

… defined (#54) * [PHPStan] Fix PHPStan notice explicit * [ci-review] Rector Rectify --------- Co-authored-by: GitHub Action <[email protected]>
rectorphp · May 4, 2023 · 3209c44 · 3209c44
1 parent 23e55c6
commit 3209c44
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 12 deletions.
diff --git a/phpstan.neon b/phpstan.neon
@@ -94,9 +94,3 @@ parameters:
 
         # class-string
         - '#Parameter \#2 \$expectedClass of method Rector\\NodeAnalyzer\\MethodCallTypeAnalyzer\:\:isInstanceOf\(\) expects class\-string, string given#'
-
-        -
-            message: '#Attribute must have all names explicitly defined#'
-            paths:
-                - tests
-                - rules-tests
diff --git a/rules/DowngradePhp72/Rector/FuncCall/DowngradeJsonDecodeNullAssociativeArgRector.php b/rules/DowngradePhp72/Rector/FuncCall/DowngradeJsonDecodeNullAssociativeArgRector.php
@@ -105,8 +105,7 @@ public function refactor(Node $node): ?Node
 
         // add conditional ternary
         $nullIdentical = new Identical($associativeValue, $this->nodeFactory->createNull());
-        $ternary = new Ternary($nullIdentical, null, $associativeValue);
-        $args[1]->value = $ternary;
+        $args[1]->value = new Ternary($nullIdentical, null, $associativeValue);
 
         return $node;
     }

diff --git a/rules/DowngradePhp80/Rector/MethodCall/DowngradeNamedArgumentRector.php b/rules/DowngradePhp80/Rector/MethodCall/DowngradeNamedArgumentRector.php
@@ -105,8 +105,7 @@ private function removeNamedArguments(MethodCall | StaticCall | New_ | FuncCall
             return null;
         }
 
-        $unnamedArgs = $this->unnamedArgumentResolver->resolveFromReflection($functionLikeReflection, $args);
-        $node->args = $unnamedArgs;
+        $node->args = $this->unnamedArgumentResolver->resolveFromReflection($functionLikeReflection, $args);
 
         return $node;
     }

diff --git a/src/PhpDocDecorator/PhpDocFromTypeDeclarationDecorator.php b/src/PhpDocDecorator/PhpDocFromTypeDeclarationDecorator.php
@@ -78,8 +78,10 @@ public function decorateReturn(ClassMethod|Function_|Closure|ArrowFunction $func
 
         // if nullable is supported, downgrade to that one
         if ($this->isNullableSupportedAndPossible($returnType)) {
-            $returnTypeNode = $this->staticTypeMapper->mapPHPStanTypeToPhpParserNode($returnType, TypeKind::RETURN);
-            $functionLike->returnType = $returnTypeNode;
+            $functionLike->returnType = $this->staticTypeMapper->mapPHPStanTypeToPhpParserNode(
+                $returnType,
+                TypeKind::RETURN
+            );
 
             return;
         }