Forward compatibility with react/event-loop 1.0 and 0.5 while still supporting 0.4 #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, shouldn't |
WyriHaximus
force-pushed
the
react-eventloop-1.0-0.5-0.4
branch
from
a84e6d7
to
d47073e
Compare
|
@tsufeki yes yes it should. Not sure where that went wrong so I added it and repushed it all in a single commit. |
|
Thanks for the PR, I'm excited to see support for signal handling! This should give me the motivation I need to address recoilphp/recoil#86, which I've let sit for a couple of years now! |
|
You're welcome, and glad to hear you like the new features in 0.5 🎉 |
|
Quick follow up question/request, is there any change of a new tag with this and other fixes/changes since |
|
Thank you so much ❤️ ! (This package was the last one blocking using 0.5 without tricks in production 😂 .) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've just released
react/event-loop0.5 which will be our last BC breaking release before 1.0. And aside from a few minor changes,recoil/reactis fully compatible 🎉 .