Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Movie_Analysis Page #218

Merged
merged 2 commits into from
Jul 21, 2024
Merged

Fixed Movie_Analysis Page #218

merged 2 commits into from
Jul 21, 2024

Conversation

Ishitva744
Copy link
Contributor

@Ishitva744 Ishitva744 commented Jul 20, 2024

Related Issue

Fixes #217

Description

-Fixed the movie analysis page.
-Added an option selection feature for the type of file encoding and appropriate error handling.
-Also fixed analyze_reviews function in utils.py to have parameter of column name as per the uploaded user csv file.

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / videos (if applicable)

Screenshot (92)
Screenshot (93)
Screenshot (95)
Screenshot (96)
Screenshot (97)

Checklist:

  • I have performed a self-review of my code
  • I have read and followed the Contribution Guidelines.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional context:

Added select option for file encoding and fixed bugs in function and code
Fixed analyze_review function parameters for dynamic column name of csv file uploaded by the user
Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@sanjay-kv sanjay-kv merged commit e8ac08a into recodehive:main Jul 21, 2024
2 checks passed
@sanjay-kv
Copy link
Member

awesome

@Ishitva744
Copy link
Contributor Author

Thank you so much for accepting the pull request! I'm glad you found it awesome. Also, thank you for the opportunity to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The movie analysis page is not working
2 participants