circular resume touch fixes #2022
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fire-light42
requested changes
Oct 18, 2025
| android:layout_gravity="center" | ||
| android:layout_marginStart="10dp" | ||
| android:gravity="center" | ||
| android:letterSpacing="0.09" |
| android:layout_marginStart="10dp" | ||
| android:gravity="center" | ||
| android:letterSpacing="0.09" | ||
| android:textColor="?attr/black" |
There was a problem hiding this comment.
Why? This does not match the other buttons color at all.
| tools:ignore="RtlSymmetry" | ||
| android:letterSpacing="0.09" | ||
| android:textAllCaps="false" | ||
| android:textColor="?attr/black" |
| tools:text="69m remaining" | ||
| android:textStyle="bold" | ||
| tools:ignore="RtlSymmetry" | ||
| android:letterSpacing="0.09" |
| observeNullable(viewModel.movie) { data -> | ||
| resultBinding?.apply { | ||
| resultPlayMovie.isVisible = data is Resource.Success | ||
| resultPlayMovie.isVisible = data is Resource.Success && (viewModel.resumeWatching.value == null) |
There was a problem hiding this comment.
This looks like it could be a race condition. Please do not do logic that depends on two different values.
|
@fire-light42 I think previously fixes are not that good. Making clickable and focusable to false solved click issue i didn't noticed that before, and moving watching observable below movie solved play movie visibility issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.