Read Recharts version from npm #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckifer
requested changes
Nov 27, 2023
| {localeGet(locale, 'home', 'install')} | ||
| v{rechartsPackageJson.version} | ||
| {process.env.RECHARTS_LATEST_VERSION ? ` v${process.env.RECHARTS_LATEST_VERSION}` : undefined} |
There was a problem hiding this comment.
one note is that we still need to update recharts version every time we upgrade in package.json
Can you update the recharts version in this repo to be latest instead of a specific tag?
ckifer
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to read the latest version of Recharts available from
recharts/package.jsondirectly, but it meant we had to update Recharts every time we were releasing a new version.Starting from now, we'll just need to trigger a new deployment of the website manually and as part of the build process, we fetch the latest version available for Recharts from npm API.
I also took the liberty to change the padding a little bit between the icon and the text: