ci: Fix Docker build workflow

[matthewfeickert]

Fix the Docker build CI

To run recast run testing/busyboxtest --backend docker ensure that the environmental variable RECASE_DOCKER_IMAGE is set to the value of the image that was just build in CI. Additionally, running recast locally requires that it is both installed and that graphviz is installed too.

To run recast run testing/busyboxtest --backend docker in GitHub Actions CI requires some additional work to get the Docker in Docker setup. For the time being, be content with the build tests of the Dockerfile and local testing elsewhere.

c.f. Issue #50

The equivalent to running

recast run testing/busyboxtest --backend local

is still being run in

recast-atlas/.github/workflows/ci.yml

Lines 44 to 46 in 4eba02e

	- name: Run unit tests
	run: |
	python -m pytest tests

[matthewfeickert]

@lukasheinrich How important is it that the base image is Alpine based?

recast-atlas/docker/Dockerfile

Lines 1 to 2 in 1a95c00

	FROM docker:20.10.5
	RUN apk add py-pip automake autoconf libtool \

$ docker run --rm docker:20.10.5 /bin/sh -c 'cat /etc/os-release'
NAME="Alpine Linux"
ID=alpine
VERSION_ID=3.13.4
PRETTY_NAME="Alpine Linux v3.13"
HOME_URL="https://alpinelinux.org/"
BUG_REPORT_URL="https://bugs.alpinelinux.org/"

[lukasheinrich]

@matthewfeickert no it doesn't.. it might date back to a timee where I didn't quite appreciate that alpine is not that great ;)

[matthewfeickert]

it might date back to a timee where I didn't quite appreciate that alpine is not that great ;)

Okay cool. 🙂 Great for many things!...just not always Python wheels. :P

[lukasheinrich]

ah another reason is that the base image (for docker in docker) is based no alipine

[matthewfeickert]

ah another reason is that the base image (for docker in docker) is based no alipine

I don't actually have much experience with docker in docker workflows. Is there anything in particular we need to care about there? Or should we just be able to update to using python:3.8-slim-buster as the base image?

[lukasheinrich]

if we can install the docker daemon in that image, that could work, but I haven't tried that.

[matthewfeickert]

@lukasheinrich This is ready for review. Let me know if you have any questions.

We can change the Docker image itself in another PR.

[matthewfeickert]

(sorry, hit "request review" about a second after you hit "approve" so it sent it back to you)

[matthewfeickert]

@lukasheinrich This is ready to go in if you're happy with it.

[matthewfeickert]

@lukasheinrich just pinging. If there's nothing else to do here now this is ready for merge.

[lukasheinrich]

Thanks!