-
Notifications
You must be signed in to change notification settings - Fork 45
Update leaderboard button styling for better visibility and differentiation #1300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the styling of a leaderboard button to improve visibility and differentiation by changing its color scheme from white background to blue background.
- Changed button background from white to blue-500 for better visibility
- Updated hover states to maintain proper contrast and visual feedback
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
📊 Test Coverage Report
|
|
@timothyylim not sure if this should go in or #1312 |
|
They are almost identical, so probably doesn't matter. I'll stop picking these up so I don't trample your PRs! Having said that I personally like this one because it keeps the white border, but it's @stephhuynh18's call! |
|
i'll defer to @jovirecall #1312 or this one? You discussed this one with @carsonfarmer butttt you also approved @timothyylim's in the linear ticket. |
|
Meh, just use the other one, it looks great! |
Change previously discussed with Jovi
Fixes APP-453