#30 update Reablocks, fix focus on session change #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for reachat-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
amcdnl
reviewed
Aug 13, 2024
| useContext(ChatContext); | ||
| const [message, setMessage] = useState<string>(''); | ||
| const inputRef = useRef<HTMLTextAreaElement | null>(null); | ||
|
|
||
| useEffect(() => { | ||
| if(inputRef && inputRef.current) { |
There was a problem hiding this comment.
inputRef is a ref so it will always be there - so i don't think you need the if(inputRef part.
There was a problem hiding this comment.
will it? it could be null but i guess you could simplify with inputRef?.current
amcdnl
reviewed
Aug 13, 2024
| @@ -1093,3 +1093,106 @@ export const ImageFiles = () => { | |||
| </div> | |||
| ); | |||
| }; | |||
|
|
|||
| export const Working = () => { | |||
There was a problem hiding this comment.
it's a "working" version - i made it to test the input stuff, but decided it might be useful to have something that functions even as state variables
There was a problem hiding this comment.
ok i removed it from the main - we can add it back just needs a better name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #30
What is the new behavior?
Textarea is now focused on any chance in session including new session being created.
Also, added a sample "working" story for the console
Screen.Recording.2024-08-12.at.8.55.29.PM.mov
Does this PR introduce a breaking change?
Other information