Repository navigation
test: fold genesis RPC edges onto rpc_regtest_from_genesis - #1035
Merged
Merged
Conversation
These checks already run through dispatch on the hub that journey opens. They do not mine a second chain or keep a private context. The min-relay bump is restored before the later beats.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Twelve unit tests repeated RPC reads and rejects on a private
ctx_emptyor a second regtest hub.rpc_regtest_from_genesisalready opens one hub and callsdispatch. Those checks now run on that client:getblockcount0 was alreadytip_countat the end of the genesis refusals.getrawtransactionand REST/tx) and is not a UTXO after the journey's first block (gettxoutand REST/getutxos).estimatesmartfee/estimaterawfeeempty-result shape, conf-target gates, and the CLN target loop.getmempoolinfoconstant fields, including a min-relay bump that is restored to the value the hub already had.scantxoutsetmatches an unknown method.gettxoutsetinfo,combinerawtransaction, andsyncwithvalidationinterfacequeuestay unlisted.decoderawtransactionkeeps a segwit coinbase witness.getblockstatserror needles use the headers-only block this journey already submits.No second chain, server, or pad. Test-only. No changelog.
Test plan
cargo fmt -p rbitcoin-rpccargo clippy -p rbitcoin-rpc --tests -- -D warningscargo test -p rbitcoin-rpc rpc_regtest_from_genesisqc,test,windows,macos,coverage