Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only depend on mypy.api #8

Merged
merged 2 commits into from
Mar 16, 2018
Merged

Only depend on mypy.api #8

merged 2 commits into from
Mar 16, 2018

Conversation

dmtucker
Copy link
Collaborator

@dmtucker dmtucker commented Mar 7, 2018

Fixes #6

I think we should strongly discourage such use of interfaces internal to mypy. The only public APIs are the command line and the mypy.api module.
python/mypy#4681 (comment)

dmtucker and others added 2 commits March 7, 2018 00:56
Mypy itself needs Python 3.4 at least, citing it's README.md:

> You need Python 3.4 or later to run mypy
@dmtucker
Copy link
Collaborator Author

dmtucker commented Mar 7, 2018

I hit the same Python 3.3 failure as @petr-muller in #7:
https://travis-ci.org/dbader/pytest-mypy/jobs/350216845

@petr-muller
Copy link
Contributor

Yup, this looks even better!

@dmtucker
Copy link
Collaborator Author

dmtucker commented Mar 8, 2018

Another data point for dropping Python 3.3:

| python_version | download_count |
| -------------- | -------------- |
| 3.6            |          9,940 |
| None           |          5,010 |
| 3.5            |            941 |
| 3.4            |            443 |
| 1.17           |            267 |
| 2.7            |            157 |
| 3.7            |             62 |
| 3.3            |              4 |

There have been very few 3.3 downloads in the last year.
(Produced with pypinfo --days 365 pytest-mypy pyversion)

@dbader
Copy link
Member

dbader commented Mar 16, 2018

Thanks! LGTM :-) If anybody helps with maintaining & possibly growing this project ping me and I'll add you as a collaborator. I've got too much on my plate right now and I'm not doing a good job at supporting this project.

@dbader dbader merged commit 5cb572e into realpython:master Mar 16, 2018
@dmtucker dmtucker deleted the mypy-api branch March 17, 2018 23:52
@dmtucker
Copy link
Collaborator Author

@dbader I'd be interested (more for maintenance than dev, but hey, who knows).

#9 is another option.

@dbader
Copy link
Member

dbader commented Mar 18, 2018

Hey @dmtucker, just sent you an invite to add you as a collaborator :-)

@dmtucker dmtucker added this to the 0.3.1 milestone Apr 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants