Fix PseudoType #1815
Merged
Fix PseudoType #1815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…obust by implementing noSuchMethod to always throw.
nielsenko
force-pushed
the
kn/fix-1813-pseudotype-broken
branch
from
0bd05ba to
ac2a87c
Compare
nirinchev
approved these changes
Jan 2, 2025
nirinchev
added a commit
that referenced
this pull request
Jan 2, 2025
* add deprecation notice to README.md * fix docs link * RDART-1087: Update compileSdkVersion to fix android:attr/lStar not found (#1797) * Fix PseudoType (#1815) * Fix for added member element3. Try to make the hack PseudoType more robust by implementing noSuchMethod to always throw. * Fix ejson_lint after LintCode from analyser has become public * Update CHANGELOG * Update CHANGELOG.ejson.md * Fix android emulator test (#1816) * Fix android emulator test * try 2 * Install newer Java * Use 17 * Use gradle 8.5.0 and Java 21 * Update gradle-wrapper.properties * Try to overwrite the gradle cache * Try disabling the cache * Update test gradle packages, revert package properties * More fixes * Upgrade to gradle 8.7 * Revert * Re-enable cache * [Release 3.4.2] (#1817) Co-authored-by: nirinchev <[email protected]> * Add vNext Changelog header (#1818) Co-authored-by: nirinchev <[email protected]> --------- Co-authored-by: Michael O'Brien <[email protected]> Co-authored-by: Tianze Ds <[email protected]> Co-authored-by: Kasper Overgård Nielsen <[email protected]> Co-authored-by: Yavor Georgiev <[email protected]> Co-authored-by: nirinchev <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
PseudoTypeextends the abstract classTypeImplfrom the analyzer package. This makes it brittle in the face of interface changes to said class, which can occur without warning as the class is internal.This PR tries to make it a little more "robust", by dodging compile time errors on changes to
TypeImpl. This is done by implementingnoSuchMethod. If any new members are added, we will no longer get a compile time error.We throw an exception, if the unexpected member is actually called, but that should not happen as instances of
PseudoTypeare only used internally by the realm_generator.I think it is an acceptable compromise as this code will only ever run on the developers machine, when updating realm models. I think it is a better fix than #1814.
Fix: #1813