Github composite action for setting up flutter on runner #1710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 9379428366Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9379691723Details
💛 - Coveralls |
nielsenko
force-pushed
the
kn/setup-runner-ci-action
branch
2 times, most recently
from
d04f88f to
626d404
Compare
Pull Request Test Coverage Report for Build 9383223384Details
💛 - Coveralls |
nielsenko
force-pushed
the
kn/setup-runner-ci-action
branch
4 times, most recently
from
ffb1b12 to
e9ce82f
Compare
Pull Request Test Coverage Report for Build 9383681097Details
💛 - Coveralls |
nielsenko
force-pushed
the
kn/setup-runner-ci-action
branch
2 times, most recently
from
86a5743 to
5b49bd5
Compare
Pull Request Test Coverage Report for Build 9384312507Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9385985556Details
💛 - Coveralls |
nirinchev
reviewed
Jun 6, 2024
| # Saving on feature branches will only benefit reruns, so we don't bother. | ||
| # Feature branches inherit the cache from the main branch anyway. | ||
| # This saves on cache storage. | ||
| if: github.ref != 'refs/heads/main' && steps.restore.outputs.cache-hit != 'true' |
There was a problem hiding this comment.
Should this be github.ref == 'refs/heads/main'? Also, we seem to be only be storing the cache if we don't have a cache hit, but then we use the cache primary key as input to the save action, which seems odd.
There was a problem hiding this comment.
@nirinchev You are a bit early 😊 . Yes it should be ==.. the != is just for debugging. I'm hoping to have pingbird/puro#87 resolved first.
You cannot update a cache in github actions, only write a new one. So if you have an exact hit, trying save on the same key would fail. The primary key is the key we tried to lookup, and where we will store the updated cache, if either none existed, or the one matched pertained to a stale set of pubspec.yaml files, and hence was only a partial match.
Pull Request Test Coverage Report for Build 9400014073Details
💛 - Coveralls |
nielsenko
force-pushed
the
kn/setup-runner-ci-action
branch
from
544c233 to
a12009e
Compare
Pull Request Test Coverage Report for Build 9405930441Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9406859191Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9407048257Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9407048257Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
nielsenko
force-pushed
the
kn/setup-runner-ci-action
branch
from
140bba5 to
05bc8f3
Compare
Pull Request Test Coverage Report for Build 9407808197Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9408181155Details
💛 - Coveralls |
nielsenko
force-pushed
the
kn/setup-runner-ci-action
branch
from
5929bfa to
4dcad23
Compare
Pull Request Test Coverage Report for Build 9414059395Details
💛 - Coveralls |
|
@nirinchev I think I will accept that caching is simply disabled on windows for now. So I have opened the PR for review. |
nielsenko
force-pushed
the
kn/setup-runner-ci-action
branch
from
c46ae7e to
953e761
Compare
Pull Request Test Coverage Report for Build 9414806581Details
💛 - Coveralls |
nirinchev
approved these changes
Jun 7, 2024
nirinchev
added a commit
that referenced
this pull request
Jun 12, 2024
* main: Add vNext Changelog header (#1717) [Release 3.0.0] (#1716) libraryVersion moved to realm_libary.dart (take 2) libraryVersion moved to realm_libary.dart Update CHANGELOG (#1715) Github composite action for setting up flutter on runner (#1710) RDART-866: kn/decimal128 web support (#1713) Reduce expected gain of memEquals for test stability Refresh after awaiting download to stabilize tests RDART-866: Minimal web support (#1699) RDART-1052: Update realm-core to v14.9.0 (#1704) RDART-1020: Fix writeAsync behaviour (#1666) RDART-999: Fix flutter test dlopen (#1623) RDART-1045: Expose setrlimit ios (#1700) RDART-962: Use xcode 15.4 (#1548) RDART-1039: Drop catalyst support. Flutter doesn't support it (#1696) # Conflicts: # packages/realm_dart/src/realm-core
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
subosito/flutter-action@v2with a puro based setup.D:drive (same as$GITHUB_WORKSPACE) for IO speed.Currently caching is disabled on windows, but this PR is still faster wrt. to flutter setup on windows, than what we currently use. However, it is mostly for the simplifications we should consider this. Overall the setup steps in our jobs does n't contribute a lot to the full runtime.