Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: TipKit rule triggers an empty_count violation #5918

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Ueeek
Copy link
Contributor

@Ueeek Ueeek commented Dec 28, 2024

resolve #5883
Skip TipKit RuleMacro in EmptyCountRule

@Ueeek Ueeek marked this pull request as draft December 28, 2024 05:40
@Ueeek Ueeek force-pushed the bug/skipTipKitRuleMacroInEmptyCountRule branch from e0df3d7 to e69e152 Compare December 28, 2024 05:49
@SwiftLintBot
Copy link

SwiftLintBot commented Dec 28, 2024

17 Messages
📖 Linting Aerial with this PR took 0.94s vs 0.94s on main (0% slower)
📖 Linting Alamofire with this PR took 1.28s vs 1.29s on main (0% faster)
📖 Linting Brave with this PR took 6.65s vs 6.67s on main (0% faster)
📖 Linting DuckDuckGo with this PR took 5.48s vs 5.53s on main (0% faster)
📖 Linting Firefox with this PR took 11.11s vs 11.19s on main (0% faster)
📖 Linting Kickstarter with this PR took 10.42s vs 10.39s on main (0% slower)
📖 Linting Moya with this PR took 0.54s vs 0.54s on main (0% slower)
📖 Linting NetNewsWire with this PR took 2.96s vs 2.96s on main (0% slower)
📖 Linting Nimble with this PR took 0.79s vs 0.8s on main (1% faster)
📖 Linting PocketCasts with this PR took 8.75s vs 8.84s on main (1% faster)
📖 Linting Quick with this PR took 0.45s vs 0.45s on main (0% slower)
📖 Linting Realm with this PR took 4.58s vs 4.55s on main (0% slower)
📖 Linting Sourcery with this PR took 2.35s vs 2.35s on main (0% slower)
📖 Linting Swift with this PR took 4.6s vs 4.61s on main (0% faster)
📖 Linting VLC with this PR took 1.28s vs 1.27s on main (0% slower)
📖 Linting Wire with this PR took 18.47s vs 18.41s on main (0% slower)
📖 Linting WordPress with this PR took 11.58s vs 11.59s on main (0% faster)

Generated by 🚫 Danger

@Ueeek Ueeek marked this pull request as ready for review December 28, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Event-based TipKit rule triggers an empty_count violation
2 participants