Skip to content

Commit

Permalink
chore: remove the ProofWidgets import (#11877)
Browse files Browse the repository at this point in the history
This follows on from #11350, following an alternative suggestion by @digama0.

One argument for this pattern is that it also works for tests that import `ProofWidgets.Demos.*`, and any other auxiliary content in upstream packages that is not part of the top-level package.
  • Loading branch information
eric-wieser committed Apr 4, 2024
1 parent 89a00da commit e545009
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 7 deletions.
8 changes: 6 additions & 2 deletions GNUmakefile
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,20 @@ SHELL=/usr/bin/env -S bash -o pipefail

TESTS := $(shell find test -name '*.lean')

.PHONY: all build test lint
.PHONY: all build test lint testdeps

all: build test

build:
lake build

testdeps: build
# add any extra targets that tests depend on here
lake build ProofWidgets

test: $(addsuffix .run, $(TESTS))

test/%.run: build
test/%.run: testdeps
lake env lean test/$* | scripts/check_silent.sh test/$*.log

lint: build
Expand Down
5 changes: 0 additions & 5 deletions Mathlib/Tactic/Common.lean
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,6 @@ import Qq
-- Tools for analysing imports, like `#find_home`, `#minimize_imports`, ...
import ImportGraph.Imports

-- Currently we don't need to import all of ProofWidgets,
-- but without this, if you don't run `lake build ProofWidgets` then `make test` will fail.
-- Hopefully `lake` will be able to handle tests later.
import ProofWidgets

-- Now import all tactics defined in Mathlib that do not require theory files.
import Mathlib.Mathport.Rename
import Mathlib.Tactic.ApplyCongr
Expand Down

0 comments on commit e545009

Please sign in to comment.