-
Notifications
You must be signed in to change notification settings - Fork 3
Organizations: allow uploading avatar #614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking pretty close, though the display of the form field looks a bit janky with the text above. We should tune that a bit more.
height="48" | ||
width="48" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need either attribute here? The CSS classes should control dimensions on this, the 48 pixels on the gravatar tag was mostly to reduce the response size I think.
@@ -66,7 +65,11 @@ | |||
{% endblock list_item_right_buttons %} | |||
|
|||
{% block list_item_image %} | |||
<img class="ui image" src="{% gravatar_url object.email 48 %}" /> | |||
<img class="ui image" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you might want the same micro rounded
classes here:
<img class="ui image" | |
<img class="ui micro rounded image" |
I'd check the social account listing template and maybe try what is there too.
height="48" | ||
width="48" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here on attributes, you might be able to remove this with CSS classes added above
And just reviewed the underlying. The templates here need to support ImageField better, but that can be separate work. This will take working with the SUI crispy templates in this repo, they are a little hard to work with and fairly complicated. We can tune afterwards, but maybe lets make an issue to track |
Screencast.From.2025-06-17.12-56-08.mp4
Looks like the error message from file fields is duplicated, I think we are overriding how we render fields in the new theme somewhere...
Matches readthedocs/readthedocs.org#12254