feat(spectral): esm again #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erunion
reviewed
Sep 8, 2023
| @@ -2,12 +2,16 @@ | |||
| "name": "@readme/spectral-config", | |||
| "version": "3.0.6", | |||
| "description": "ReadMe coding standards for API documentation", | |||
| "main": "src/index.js", | |||
| "main": "dist/index.cjs", | |||
There was a problem hiding this comment.
do you need the exports: {} stuff here?
There was a problem hiding this comment.
i don't think so, i've been QA'ing using the readme-metrics-api main repo it works with this spectral config:
erunion
approved these changes
Sep 8, 2023
kanadgupta
commented
Sep 8, 2023
| "lint": "eslint .", | ||
| "prepack": "npm run build", |
There was a problem hiding this comment.
@erunion is this the only thing needed for lerna to build the dist before publishing?
There was a problem hiding this comment.
might add a prebuild for blowing away the dist directory too. i dont know if the tsup clean directory will do that or not.
"prebuild": "rm -rf dist/"
There was a problem hiding this comment.
i think we should be okay on that front b/c clean: true in the tsup config
edit: sorry just saw the second part of your comment lol i confirmed it cleans it out properly!
kanadgupta
added a commit
that referenced
this pull request
Sep 8, 2023
This reverts commit bb437f8.
erunion
pushed a commit
that referenced
this pull request
Sep 8, 2023
kanadgupta
added a commit
that referenced
this pull request
Sep 8, 2023
erunion
pushed a commit
that referenced
this pull request
Sep 8, 2023
kanadgupta
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
We were running into issues with
alexnot being properly bundled but thanks totsupwe're now including it in the dist. This SHOULD work now :cry-party:(Tagging #744 #724 #718 for posterity)
🧬 QA & Testing
I've been QA'ing by linking the package manually with the following Spectral config in a separate repository:
Instead of the reckless non-QA approach I took in previous PRs, I actually feel good about this QA process translating to actual experience using the package.