fix(openapi/upload): more edge case handling for URL uploads #1348
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
expanding on the work from #1344, this PR tweaks a bunch of logic / DX improvements to better account for the following
rdme openapi upload
edge cases:rdme openapi upload https://example.com --custom-slug.json
) will now properly read that file and set that slugrdme openapi upload https://example.com --custom-slug.yml
) will now properly read that file and set that slug--slug
passed (e.g.,rdme openapi upload https://example.com
) will now default toopenapi.json
and emit a warning about this behavior--slug
passed (e.g.,rdme openapi upload https://example.com/some-path
) will now properly handle JSON/YAML and set the slug to that path (e.g.,some-path.json
). [applicable for both creates and updates]🧬 QA & Testing
honestly the more test cases i added, the more rework i realized this logic required 😮💨 the fact that they're passing brings me a lot of comfort here lol