Skip to content

fix: failing tests (multipart-formdata) #1028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025
Merged

Conversation

AndriiAndreiev
Copy link
Collaborator

@AndriiAndreiev AndriiAndreiev commented May 8, 2025

🧰 Changes

Fixes three failing tests in packages/core/test/index.test.ts under APICore > #fetch > multipart/form-data in Node.js 24:

  • should support multipart/form-data requests
  • should support plaintext files
  • should support plaintext files containing unicode characters

Node.js 24 (latest version) appends a newline (\n) to the final multipart/form-data boundary, causing data.requestBody to end with "--\n" instead of "--" expected by tests.

🧬 QA & Testing

Run npm run test to run unit tests

@AndriiAndreiev AndriiAndreiev marked this pull request as ready for review May 8, 2025 14:25
@erunion erunion merged commit ae93ae9 into main May 27, 2025
9 checks passed
@erunion erunion deleted the fix/node-24-form-data-tests branch May 27, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants