Fix #49: Add additional Japanese localization strings provided by toshiakikoike #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkwright
changed the title
rkwright
changed the title
|
Hello, |
|
Is there still interest in having this done, or should I close it out? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is Finalized
Related issue(s) and/or pull request(s)
#49
Test cases, sample files
My Japanese is rusty, so I validated each new string by looking it up in Google translate and making sure that it was at least a reasonable approximation of the English version (and not, for example, Spam.)
I had to test in Firefox because for some reason the navigator.userLanguage was undefined and navigator.language was en_US in Chrome (Ubuntu 14.04), even though I set my browser preferences to Japanese. In Firefox, I could see and confirm some of the new strings under the Settings->Style menu and they looked fine.
Additional information