Fixes for inefficient reads of ZIP entries #273
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the sake of readium/cli#27
Read
calls that aren't obligated to return the entirety of a resourceRange: bytes=0-
then abort when satisfied, which is already hopeless for us to handle. At least when users scrub through video/audio, we can take aRange: bytes=XXXXXX-
header and start the remote range request for the resource at the start of the byte range.Still getting
ERROR failed streaming asset error="resource: error 500: flate: corrupt input before offset 5"
, need to fix that before this becomes a proper PR because there's a bug somewhere