Support ignoring images based on hash when inferring nonvisual reading #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
necessitated passing of context to inference functions
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for ignoring specific images based on their hash when inferring nonvisual reading, updates the accessibility metadata inference functions, and improves the image analysis functionality.
- Added a new config option (InferIgnoredImages) and utility functions (String, Equal, Find) for hash handling.
- Renamed and refactored accessibility metadata inference and image inspection functions.
- Updated tests to validate the new behavior with ignored images.
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pkg/streamer/streamer.go | Introduced InferIgnoredImages config and updated the inference flow. |
| pkg/streamer/a11y_infer_test.go | Updated tests to use the new signature for accessing accessibility metadata. |
| pkg/streamer/a11y_infer.go | Modified inference function to return errors and handle ignored images. |
| pkg/manifest/properties_hash.go | Added convenience functions for HashValue and HashList. |
| pkg/manifest/properties.go | Refactored property getters to use consistent patterns. |
| pkg/analyzer/image_test.go | Added tests for InspectImage and MatchImage functionality. |
| pkg/analyzer/image.go | Renamed and refactored the image inspection logic to support computed hashes. |
| CHANGELOG.md | Updated changelog to document added and changed features. |
mickael-menu
reviewed
May 7, 2025
pkg/manifest/properties.go
Outdated
| return nil | ||
| } | ||
| if enc, ok := v.(Encryption); ok { | ||
| // Is already an Encryption struct |
There was a problem hiding this comment.
Link Properties must only contain JSON data specifically to avoid this ambiguity and facilitate the serialization of the manifest to JSON. If there are Encryption or HashList objects in Properties, they need to be serialized at the location where they are added to Properties.
There was a problem hiding this comment.
@mickael-menu I changed it, look OK?
mickael-menu
approved these changes
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Toolkit portion of the work for readium/cli#15
From the changelog:
Added
Streamer:InferIgnoredImages, a list of hashes of images to ignore when when inferring nonvisual readinganalyzer.MatchImagefunction that compares an image link's hashes with given hashes to check for a matchHashValuehas newStringandEqualconvenience functions.HashListhas a newFindconvenience function.Changed
analyzer.Imagetoanalyzer.InspectImage