-
-
Notifications
You must be signed in to change notification settings - Fork 854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update packages version and ready for pnpm #1333
Conversation
✅ Deploy Preview for reactplayio ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
We should upgrade all the dependencies since a few of them have become deprecated. @Angra974 |
Updating all the dependencies means to modify codes inside the application ( change between swiper 9 to 10 ). |
This one is ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good 🎉
so now we need to change the docs according to |
Description
Using pnpm to install the application is beneficial if you install often packages or if you have a slow network with other benefits. pnpm store the packages in a folder and use them when needed instead of download them again.
Nevertheless, we have a warning with the current installation regarding eslint :
We need to adjust the dependencies so we can take off this warning.
Before, some people was unable to install with pnpm too because of this problem with eslint.
Fixes #1189
Type of change
Updated the dependencies and their peer dependencies to get no more warning
Only package.json and eslintrc.js was changed by my work.
The other files result in the format and lint of the file with the new version of the modules.
Please delete options that are not relevant.
How Has This Been Tested?
Lint after install the current reactplay.
Update the dependencies and the related peer dependencies
Lint after update.
Add configuration in .eslintrc.js to get warnings instead of errors for unused vars.
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
=> the basic lint command.
Checklist:
Screenshots or example output
video



Remark: Husky commit use Yarn, so ^^'
Notice :
i've updated the .gitignore file to :