Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hello 3.x development branch #272

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Conversation

WyriHaximus
Copy link
Member

@WyriHaximus WyriHaximus commented Jan 23, 2024

Once this PR is merged, we can start working on the new v3.0.0 milestone. The default branch will be 3.x and the old 1.x branch still stay in place at least until 3.0.0 is released.

Refs:
Road map ticket for event-loop: #271
Plans for ReactPHP v3: https://github.com/orgs/reactphp/discussions/481
PR templated from: friends-of-reactphp/mysql#185

@WyriHaximus WyriHaximus added this to the v3.0.0 milestone Jan 23, 2024
Copy link
Member

@SimonFrings SimonFrings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some small remarks below, maybe it's also a good idea to add the source where we based this PR on (friends-of-reactphp/mysql#185). Let's add this to the description so we can simply copy-paste this for the upcoming 3.x branch pull requests in our other repositories 👍

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@WyriHaximus WyriHaximus force-pushed the 3.x-development branch 2 times, most recently from 6da4b30 to a289d8f Compare January 24, 2024 16:28
@WyriHaximus
Copy link
Member Author

@SimonFrings Updated with suggested changes

Added some small remarks below, maybe it's also a good idea to add the source where we based this PR on (friends-of-reactphp/mysql#185). Let's add this to the description so we can simply copy-paste this for the upcoming 3.x branch pull requests in our other repositories 👍

This is exactly why I haven't prepared the rest of the branches yet. Once this one is good, I'll create the rest so they can be put up once the roadmap tickets has been created.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Member

@SimonFrings SimonFrings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for applying the suggested changes, looks good to me 👍

Once this PR is merged, we can start working on the new [v3.0.0 milestone](https://github.com/reactphp/event-loop/milestone/15). The default branch will be `3.x` and the old `1.x` branch still stay in place at least until `3.0.0` is released.

Refs:
Road map ticket for event-loop: reactphp#271
Plans for ReactPHP v3: https://github.com/orgs/reactphp/discussions/481
PR templated from: friends-of-reactphp/mysql#185
Copy link
Member

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WyriHaximus Nice! Now let's get started! :shipit:

@clue clue merged commit e86b09e into reactphp:3.x Jan 26, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants