support to read bootstrap server property when it was defined as a list #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@emmanuelsilva Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@emmanuelsilva Thank you for signing the Contributor License Agreement! |
This was referenced Dec 20, 2023
Closed
emmanuelsilva
changed the title
artembilan
requested changes
Jan 3, 2024
artembilan
approved these changes
Jan 10, 2024
|
thank you for contribution; looking forward for more! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #374
Introduces support for reading the boot servers when the property was defined as a List and not a String.
It will avoid a class cast exception when using reactor-kafka with Spring Boot Kafka since the Spring library configures the bootstrap servers as a list of strings and not a String object, as you can see on their implementation.