Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deactivate Milestone links for artifacts which don't have milestone versions #115

Merged
merged 2 commits into from
Aug 15, 2023
Merged

Deactivate Milestone links for artifacts which don't have milestone versions #115

merged 2 commits into from
Aug 15, 2023

Conversation

pderop
Copy link
Contributor

@pderop pderop commented Jul 12, 2023

When doing the 2022.0.9 / 2023.0.0-M1 / 2020.0.34 releases, there are some issues with the projectreactor site:

For the 2023.0.0-M1 milestone version, only the Reactor Core and the Reactor Test should have some Milestone links, and other artifacts (like Reactor Netty, Reactor Pool) should not have such links, because only Reactor Core/Test are part of the 2023.0.0-M1.

For example, when we browse the site, the Milestone links are enabled for the following artifact:

  • reactor extra (Javadoc with milestone 3.5.0-RC1)
  • reactor netty (Javadoc and Reference with milestone 1.1.0-RC1)
  • reactor adapter (Javadoc with milestone 3.5.0-RC1)
  • reactor kotling extensions (Javadoc with milestone 1.2.0-RC1)
  • reactor-pool (Javadoc with milestone 1.0.0-RC1)

This PR is an attempt to fix the problems with two fixes which allow to hide artifacts Milestone links for the components which are not part of the 2023.0.0-M1 milestone:

  1. first fix in boms.yml, where the artifacts which are not part of the 2023.0.0-M1 are commented

  2. annother fix is in docs.html, where the Reactor Netty Milestone link for the Reference is included even if it commented in the bom.yml (there is a wrong test which is testing milestone.testVersion instead of milestone. nettyVersion).

Without this PR, currently, for example we have the Milestone links that are appearing for Reactor Netty and Reactor Adapter:
Screenshot 2023-07-12 at 21 42 04

and with the proposed PR, the Milestone links are not displayed anymore:

Screenshot 2023-07-12 at 21 44 29

Admittedly, maybe there is still a problem, because the Reactor Netty and Reactor Adapter release trains don't contain anymore the 2023.0.0-M1 version ...

…-M<number>, and module versions appear in all release trains.
@pderop
Copy link
Contributor Author

pderop commented Jul 27, 2023

@reactor/core-team , can you take a look again please ?

In the last commit:

  • all release trains are now displayed for a given module version. The predicate used to decide if the Milestone button is displayed is based on the module version found from the milestone module version in the boms.yml: if the version ends with -M<digit number>, then the Milestone button is displayed, else it is not.

  • Also, added missing rabbitVersion in boms.yml.

Example:
Screenshot 2023-07-27 at 19 22 47

Thanks.

@violetagg violetagg changed the title Can't deactivate Milestone links for artifacts which don't have milestone versions. Deactivate Milestone links for artifacts which don't have milestone versions Aug 15, 2023
@violetagg violetagg merged commit 6703bc1 into reactor:main Aug 15, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants