Deactivate Milestone links for artifacts which don't have milestone versions #115
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing the 2022.0.9 / 2023.0.0-M1 / 2020.0.34 releases, there are some issues with the projectreactor site:
For the 2023.0.0-M1 milestone version, only the
Reactor Core
and theReactor Test
should have someMilestone
links, and other artifacts (like Reactor Netty, Reactor Pool) should not have such links, because only Reactor Core/Test are part of the 2023.0.0-M1.For example, when we browse the site, the
Milestone
links are enabled for the following artifact:This PR is an attempt to fix the problems with two fixes which allow to hide artifacts
Milestone
links for the components which are not part of the 2023.0.0-M1 milestone:first fix in boms.yml, where the artifacts which are not part of the 2023.0.0-M1 are commented
annother fix is in docs.html, where the
Reactor Netty
Milestone link for theReference
is included even if it commented in the bom.yml (there is a wrong test which is testingmilestone.testVersion
instead ofmilestone. nettyVersion
).Without this PR, currently, for example we have the Milestone links that are appearing for Reactor Netty and Reactor Adapter:
and with the proposed PR, the Milestone links are not displayed anymore:
Admittedly, maybe there is still a problem, because the Reactor Netty and Reactor Adapter release trains don't contain anymore the 2023.0.0-M1 version ...