Open
Conversation
jweiser
reviewed
May 21, 2021
jweiser
reviewed
May 21, 2021
src/main/java/org/reactome/release/orthopairs/UniProtGeneNamesRetriever.java
Show resolved
Hide resolved
jweiser
reviewed
May 21, 2021
| // Tab-separate UniProt accession ID and its associated gene name, and then store these in the Set that will be returned. | ||
| uniprotAccessionsToGeneNames.add(geneObject.getAccession().toString() + "\t" + geneComponent.getGeneName().toString() + "\n"); | ||
| QueryResult<UniProtComponent<Gene>> uniprotEntries = null; | ||
| while (currentAttemptNum < MAX_NUM_ATTEMPTS && uniprotEntries == null) |
Member
There was a problem hiding this comment.
Perhaps after this loop if uniprotEntries is still null (because the maximum number of attempts is gone past), a logger error to indicate that the maximum number of attempts were surpassed and no entries were retrieved (in addition to the log for an error during retrieval).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle timeouts from UniProt.