Skip to content

Fix runtime error in a broken clock challenge caused by missing element check #7866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

soralvy
Copy link

@soralvy soralvy commented Jul 11, 2025

What’s the issue?

The Clock challenge component throws a runtime error because it tries to set the className on an element that does not yet exist in the DOM. Specifically, document.getElementById('time') returns null during the initial render, causing this error:

image

This PR adds a simple existence check before accessing the element’s className, preventing the runtime error while preserving the original logic

@facebook-github-bot
Copy link
Collaborator

Hi @soralvy!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@facebook-github-bot
Copy link
Collaborator

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@soralvy soralvy marked this pull request as draft July 11, 2025 10:21
@soralvy soralvy marked this pull request as ready for review July 11, 2025 10:22
@rickhanlonii
Copy link
Member

@gaearon is the error intentional for the challenge? The text sounds like it shouldn't, but looking at the history I don't see how this would have ever worked without an error?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants