[fix] Unnecessary renders when modal is closed

reactjs · Jun 20, 2017 · 7da6ec8 · 7da6ec8
1 parent 648cc2f
commit 7da6ec8
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/src/components/Modal.js b/src/components/Modal.js
@@ -108,8 +108,12 @@ export default class Modal extends Component {
   }
 
   componentWillReceiveProps(newProps) {
-    if (newProps.isOpen) refCount.add(this);
-    if (!newProps.isOpen) refCount.remove(this);
+    const { isOpen } = newProps;
+    // Stop unnecessary renders if modal is remaining closed
+    if (!this.props.isOpen && !isOpen) return;
+
+    if (isOpen) refCount.add(this);
+    if (!isOpen) refCount.remove(this);
     const currentParent = getParentElement(this.props.parentSelector);
     const newParent = getParentElement(newProps.parentSelector);