Sync with react.dev @ 53fbed3f #54
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noticed this randomly and couldn't unsee it, so here's a quick PR to fix.
* change isOpen variable in TopNav component to isMenuOpen to differentiate from isOpen props in Search component change setIsOpen to setIsMenuOpen in TopNav component * move initialization of ShowSearch state to top-level of TopNav component organize hook initializations in TopNav component: useState, useRef, useRouter * remove initialYScroll prop from DocSearchModal component to fix search functionality on ios devices
* Add docs for onCaughtError and onUncaughtError * Updates from feedback
Note that this component is not actually expandable and the ref got likely unused when that was removed
* in \[errorCode\].tsx, wrapped parsedContent in a div and applied styling of white-space: pre-wrap to preserve whitespace and break on newline chars * updated styling to tailwind class
Tickets are sold out, update the text.
* API docs for useDeferredValue's initialValue Updates the API docs for `useDeferredValue` to include the `initialValue` option, added in facebook/react#27500. This feature is slated for release in React 19. * Add docs for onCaughtError and onUncaughtError (#6742) * Add docs for onCaughtError and onUncaughtError * Updates from feedback * Add canary info, simplify a bit --------- Co-authored-by: Ricky <[email protected]>
* Add documentation for ref cleanup functions * Contain changes within canary block
* move useFormState api * add redirect * use React DOM as the name
* Blog posts for React 19 * Feedback * Feedback * Update src/content/blog/2024/04/25/react-19.md Co-authored-by: Josh Story <[email protected]> * Update src/content/blog/2024/04/25/react-19.md Co-authored-by: Josh Story <[email protected]> * Update src/content/blog/2024/04/25/react-19.md Co-authored-by: Josh Story <[email protected]> * Update src/content/blog/2024/04/25/react-19.md Co-authored-by: Josh Story <[email protected]> * Update src/content/blog/2024/04/25/react-19.md Co-authored-by: Josh Story <[email protected]> * Update src/content/blog/2024/04/25/react-19.md Co-authored-by: Josh Story <[email protected]> * Update src/content/blog/2024/04/25/react-19.md Co-authored-by: Josh Story <[email protected]> * Update src/content/blog/2024/04/25/react-19.md Co-authored-by: Josh Story <[email protected]> * Update src/content/blog/2024/04/25/react-19.md Co-authored-by: Josh Story <[email protected]> * Update src/content/blog/2024/04/25/react-19.md Co-authored-by: Josh Story <[email protected]> * Update src/content/blog/2024/04/25/react-19.md Co-authored-by: Josh Story <[email protected]> * Update src/content/blog/2024/04/25/react-19.md Co-authored-by: Josh Story <[email protected]> * Update src/content/blog/2024/04/25/react-19.md Co-authored-by: Josh Story <[email protected]> * Update src/content/blog/2024/04/25/react-19.md Co-authored-by: Josh Story <[email protected]> * Update src/content/blog/2024/04/25/react-19.md Co-authored-by: Josh Story <[email protected]> * Update src/content/blog/2024/04/25/react-19.md Co-authored-by: Noah Lemen <[email protected]> * Update src/content/blog/2024/04/25/react-19.md Co-authored-by: Matt Carroll <[email protected]> * Update src/content/blog/2024/04/25/react-19.md Co-authored-by: Matt Carroll <[email protected]> * Update src/content/blog/2024/04/25/react-19.md Co-authored-by: Noah Lemen <[email protected]> * Update src/content/blog/2024/04/25/react-19.md Co-authored-by: Noah Lemen <[email protected]> * Update src/content/blog/2024/04/25/react-19.md Co-authored-by: Noah Lemen <[email protected]> * Update src/content/blog/2024/04/25/react-19.md Co-authored-by: Noah Lemen <[email protected]> * Update src/content/blog/2024/04/25/react-19.md * Update src/content/blog/2024/04/25/react-19.md Co-authored-by: Matt Carroll <[email protected]> * Thanks * Apply suggestions from code review Co-authored-by: Matt Carroll <[email protected]> Co-authored-by: Sebastian Silbermann <[email protected]> * Feedback * nit * Issue link --------- Co-authored-by: Josh Story <[email protected]> Co-authored-by: Noah Lemen <[email protected]> Co-authored-by: Matt Carroll <[email protected]> Co-authored-by: Sebastian Silbermann <[email protected]>
* Typos in React 19 * Headings
should assign the result of updateName Co-authored-by: Tim Neutkens <[email protected]>
* Make use(Context) example easier to understand * Update src/content/blog/2024/04/25/react-19.md Co-authored-by: Ricky <[email protected]> * Update src/content/blog/2024/04/25/react-19.md Co-authored-by: Ricky <[email protected]> * Update src/content/blog/2024/04/25/react-19.md Co-authored-by: Ricky <[email protected]> * Update src/content/blog/2024/04/25/react-19.md Co-authored-by: Ricky <[email protected]> --------- Co-authored-by: Ricky <[email protected]>
…s stable but the packages you work with as a framework and bundler will approach API stability (#6782)
Co-authored-by: Dom Zhu <[email protected]>
* Better use(Promise) example in 19 blog * Better use(Promise) example in 19 blog
Co-authored-by: OH HYUN KEUN <[email protected]>
This upstreams some of the [introduction post](reactwg/react-compiler#5) into the docs since this knowledge is quite fundamental to understanding the compiler, and it's confusing to not have it linked in the canonical source for the docs. It also adds more information about [debugging](reactwg/react-compiler#7) and reorganizes a few sections to make things clearer ghstack-source-id: ef32fc723722eb5119529abcc572dd2bcf2b1cab Pull Request resolved: reactjs/react.dev#6895
* Add React Conf 2024 Recap post * Spelling and links * Apply suggestions from code review Co-authored-by: lauren <[email protected]> * Edits * Edits * better link * Update date * Update date and nits * feedback --------- Co-authored-by: lauren <[email protected]>
* Add codemods to upgrade guide * Update src/content/blog/2024/04/25/react-19-upgrade-guide.md Co-authored-by: Ahmed Abdelbaset <[email protected]> * Add benefits --------- Co-authored-by: Ahmed Abdelbaset <[email protected]>
The docs for stylesheet precedence incorrectly state that there is an enumerated set of valid precedences. This is incorrect. The precedence value can be anything and React infers the hierarchy from the order in which it discovers precedences
* FIX: Typo in useEffect.md caveats * Fix another typo
* Add act documentation * Update structure based on feedback * Add usage examples and async act --------- Co-authored-by: Rick Hanlon <[email protected]>
Fix very minor typo
Added missing comma to the codesample.
Expo now has its own instructions for enabling the compiler.
Size changes📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
| Page | Size (compressed) |
|---|---|
global |
104.19 KB (🟡 +305 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Five Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load |
|---|---|---|
/404 |
104.28 KB (🔴 +24.53 KB) |
208.47 KB |
/500 |
104.27 KB (🔴 +24.53 KB) |
208.47 KB |
/[[...markdownPath]] |
106.12 KB (🔴 +24.6 KB) |
210.32 KB |
/errors |
104.48 KB (🔴 +24.56 KB) |
208.68 KB |
/errors/[errorCode] |
104.46 KB (🔴 +24.56 KB) |
208.66 KB |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically generated.
Merge changes from react.dev at 53fbed3
DO NOT SQUASH MERGE THIS PULL REQUEST!
Doing so will "erase" the commits from main and cause them to show up as conflicts the next time we merge.